Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in sig-scalability README #7873

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix broken links in sig-scalability README #7873

merged 1 commit into from
May 27, 2024

Conversation

yuanchen8911
Copy link
Member

@yuanchen8911 yuanchen8911 commented May 2, 2024 •
edited

This PR fixes the broken links to GitHub-Teams in the sig-scalability README file:

  1. Remove non-existing links
  2. Add two new links

Which issue(s) this PR fixes:

Fixes #7869

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from shyamjvs May 2, 2024 14:31
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t May 2, 2024 14:31
@k8s-ci-robot k8s-ci-robot added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label May 2, 2024
@yuanchen8911 yuanchen8911 mentioned this pull request May 2, 2024
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@yuanchen8911
Copy link
Member Author

/assign @wojtek-t

@wojtek-t
Copy link
Member

wojtek-t commented May 8, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@yuanchen8911
Copy link
Member Author

/assign @justaugustus

@yuanchen8911
Copy link
Member Author

/cc @parispittman

justaugustus
justaugustus approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, wojtek-t, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 38918f9 into kubernetes:master May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@justaugustus justaugustus

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in sig-scalability README file
4 participants
@yuanchen8911 @wojtek-t @k8s-ci-robot @justaugustus