Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update vendored hcloud-go to 2.8.0 #6797

Merged
merged 2 commits into from
May 28, 2024

Conversation

apricote
Copy link
Member

@apricote apricote commented May 7, 2024

What type of PR is this?

/kind cleanup
/area provider/hetzner

What this PR does / why we need it:

Update hcloud-go from 2.4.0 to 2.8.0

Generated by:

UPSTREAM_REF=v2.8.0 hack/update-vendor.sh
Replace the custom method waitForServerAction with the upstream ActionClient.WaitFor which was introduced in 2.8.0.

Which issue(s) this PR fixes:

Special notes for your reviewer:

The first commit only updates the vendored version of hcloud-go. The second replaces the custom method. Happy to split this into two PRs if requested.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Generated by:

```
UPSTREAM_REF=v2.8.0 hack/update-vendor.sh
```
I have to agree with the removed comment, the previous interface was
very weird to hold. hcloud-go 2.8.0 introduced a new `WaitFor()`
interface that simplifies this a lot. The custom handler is no longer
required.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/provider/hetzner Issues or PRs related to Hetzner provider labels May 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 7, 2024
@Shubham82
Copy link
Contributor

Thanks @apricote
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit c61e295 into kubernetes:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants