Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AliCloud(Perf): Optimize AliCloudProvider NodeGroupForNode Function #6749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guopeng0
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

if a large number of nodes are created via instances not in Managed ASGs, every call to NodeGroupForNode->GetAsgForInstance->FindForInstance will trigger a regenerateCache. If there are a significant number of instances in Managed ASGs at that time, this could lead to frequent calls, each with a considerable time overhead for regenerateCache.

For example, if there are 1000 machines in Managed ASGs and suddenly 2000 instances not in Managed ASGs are added:

UpdateNodes->updateReadinessStats->NodeGroupForNode
This call is executed with every runOnce, and each node invokes NodeGroupForNode once. The 2000 newly added instances not in Managed ASGs will trigger regenerateCache, but it will only count instances in Managed ASGs. However, it will still execute 2000 times.

Assuming each regenerateCache call takes 10 seconds, this function will take:

2000 instances * 10 seconds/instance = 20000 seconds.
This significantly extends the duration of a single runOnce operation. During this period, if new pending pods appear, the Cluster Autoscaler might not function as expected, posing a severe risk.

Proposed Solution:

The regenerateCache operation will be moved to func (ali *aliCloudProvider) Refresh() error, which will be called on every runOnce. To reduce the frequency of calls, a minimum interval between calls will be introduced. Additionally, the caching mechanism for instancesNotInManagedAsg will be removed. Instances not in instanceToAsg will return nil. By refreshing regenerateCache on every runOnce, the correct results will eventually be obtained. This modification ensures that the normal operation of the Cluster Autoscaler (CA) is not affected by the appearance of a large number of instances not in Managed ASGs.
This approach is inspired by the latest implementation in the AWS CloudProvider 867

Which issue(s) this PR fixes:

Fixes #6748

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @guopeng0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guopeng0
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guopeng0
Copy link
Contributor Author

guopeng0 commented Jun 14, 2024

Hi @feiskyer
Please review this pull request. your valuable feedback is appreciated, and I will make changes as soon as possible.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
@feiskyer
Copy link
Member

Add @ringtail could you review the change?

@ringtail
Copy link
Contributor

@IrisIris Pls take a look

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA(AliCloud):Large sudden increase in instances not managed by ASG can impact CA performance
5 participants