logcheck: support new golangci-lint plugin interface

[linxiulei]

The new plugin interface was added in golangci/golangci-lint#3887 to allow settings for custom plugins. This commit implements the new plugin interface with config value in the settings, and passes it to flag --config.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linxiulei
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

This issue is currently awaiting triage.

If logtools contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @linxiulei!

It looks like this is your first PR to kubernetes-sigs/logtools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/logtools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[pohly]

I already added such support in #18.

The problem with the approach in this PR is that changes in the content of the config file do not invalidate the golangci-lint cache because golangci-lint is unaware that the config changed. Do you agree that my approach is better?

[linxiulei]

I already added such support in #18.

Oh, I didn't find that. I am fine to discard this one if that one is better.

The problem with the approach in this PR is that changes in the content of the config file do not invalidate the golangci-lint cache because golangci-lint is unaware that the config changed. Do you agree that my approach is better?

Would golangci-lint invalidate the cache if the settings have changed?

Would having a separate config file be preferable if the content of the config file is verbose?

[pohly]

Would golangci-lint invalidate the cache if the settings have changed?

Yes.

Would having a separate config file be preferable if the content of the config file is verbose?

An #include feature in golangci-lint would be nice, but doesn't exist and is close to impossible to add. In kubernetes/kubernetes#118502 I am using templating to include the config file.

[pohly]

/close

In favor of #18

[k8s-ci-robot]

@pohly: Closed this PR.

In response to this:

/close

In favor of #18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.