Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests to lifecycle #1087

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added unit tests to lifecycle #1087

wants to merge 7 commits into from

Conversation

NeerajNagure
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds unit tests to lifecycle_test.go for several functions like ListAllPossibleStages from lifecycle,LifecycleMatch,StageMatch,StageDelay

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@NeerajNagure
added unit tests to lifecycle
3d93b3b 
Signed-off-by: Neeraj Nagure <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NeerajNagure
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @NeerajNagure!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @NeerajNagure. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2024
@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 932d84a
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/665063500d12d50008668b72

@NeerajNagure
Copy link
Author

@wzshiming I have made the required changes

wzshiming
wzshiming reviewed May 21, 2024
View reviewed changes
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
@NeerajNagure @wzshiming
update year
e1a0dde 
Co-authored-by: Shiming Zhang <[email protected]>
@NeerajNagure
Copy link
Author

@wzshiming I have made the changes can you please review it?

wzshiming
wzshiming reviewed May 24, 2024
View reviewed changes
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
pkg/utils/lifecycle/lifecycle_test.go Outdated Show resolved Hide resolved
@NeerajNagure
Copy link
Author

@wzshiming I have made all the changes suggested by you and also added a test case wherein the matchexpressions are matched

@NeerajNagure
Copy link
Author

@wzshiming can you please review this PR?

@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2024
wzshiming
wzshiming reviewed May 30, 2024
View reviewed changes
pkg/utils/lifecycle/lifecycle_test.go
}
}

func TestLifecycleMatch(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the TestStageMatch, add various test data to cover the function as possible.

pkg/utils/lifecycle/lifecycle_test.go
"sigs.k8s.io/kwok/pkg/utils/format"
)

func TestListAllPossibleStages(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming left review comments

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeerajNagure @k8s-ci-robot @wzshiming