🐛 fix: disallow files containing unwanted files when initializing a project

[afzal442]

Fixes: #4487

[k8s-ci-robot]

Welcome @afzal442!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @afzal442. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @afzal442,

That is great!

Could we just:

a) Improve the text message for:
"Target directory is not empty and contains a disallowed file %q. Files with the following extensions [%s] are not allowed to avoid conflicts with the tooling."

b) For this to be merged, we need it to be in a single commit. To maintain a clean git history and follow the general policy of Kubernetes projects (one PR, one commit, one change), could you please squash the commits? This makes it easier to revert changes if needed.

Otherwise, everything looks great here! As soon as you address these, we can get this merged.

Thank you so much for your contribution 🥇 – it's really great work!

[camilamacedo86]

/lgtm
/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afzal442, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/override pull-kubebuilder-e2e-k8s-1-32-0

[k8s-ci-robot]

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-32-0

In response to this:

/override pull-kubebuilder-e2e-k8s-1-32-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @afzal442

Can you please rebase your branch with master?
Also, see that the logic of it seems not accurate : https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kubebuilder/4510/pull-kubebuilder-test/1881642141856305152

we need to fix it.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[afzal442]

/test pull-kubebuilder-e2e-k8s-1-32-0

[k8s-ci-robot]

@afzal442: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-32-0	d2968d1	link	true	/test pull-kubebuilder-e2e-k8s-1-32-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[camilamacedo86]

/overwrite pull-kubebuilder-e2e-k8s-1-32-0

(The prow is broken)