Replace deprecated experimental.FunctionListenerFactoryKey with experimental.WithFunctionListenerFactory
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
chansuke
force-pushed
the
fix/fix-build-error
branch
from
2185828
to
c81df63
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Gekko0114
reviewed
Jun 9, 2024
internal/e2e/profiler/profiler.go
Outdated
| ctx := context.WithValue(context.Background(), | ||
| experimental.FunctionListenerFactoryKey{}, | ||
|
|
||
| // Use `WithFunctionListenerFactory` instead of ``FunctionListenerFactoryKey`. |
There was a problem hiding this comment.
You may not need this comment because this is very minor change.
There was a problem hiding this comment.
@Gekko0114
I will remove this, thanks
codefromthecrypt
approved these changes
Jun 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chansuke, codefromthecrypt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
experimental.FunctionListenerFactoryKeyis deprecated andmake checkis failing onmainbranch.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
What are the benchmark results of this change?