Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support framework.Handle #73

Open
2 of 5 tasks
sanposhiho opened this issue Oct 16, 2023 · 15 comments
Open
2 of 5 tasks

Support framework.Handle #73

sanposhiho opened this issue Oct 16, 2023 · 15 comments
Assignees
@chansuke @Gekko0114 @sanposhiho
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/next-release Issues or PRs related to features should be implemented for the next release.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 16, 2023 •
edited
Loading

The scheduler exports framework.Handle to the plugins so that they can operate something on the framework side.

https://github.com/kubernetes/kubernetes/blob/add482a2d31db938f3dca87920313db9d1780cf5/pkg/scheduler/framework/interface.go#L601

Some functions don't need to be implemented though, we should support the common ones at least:
@sanposhiho sanposhiho added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 16, 2023
@sanposhiho sanposhiho mentioned this issue Oct 23, 2023
Closed
14 tasks
@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 1, 2023 •
edited
Loading

SnapshotSharedLister might not be needed if #71 is complited, so lower priority for now.

@Gekko0114
Copy link
Member

I will work on EventRecorder

@sanposhiho
Copy link
Member Author

/assign @Gekko0114

@Gekko0114 Gekko0114 mentioned this issue Dec 6, 2023
Merged
@Gekko0114
Copy link
Member

@sanposhiho
I would like to work on another one, do you have any recommendation? (which item has higher priority?)

@sanposhiho
Copy link
Member Author

I would say RunFilterPluginsWithNominatedPods is the one.

@Gekko0114
Copy link
Member

Thanks, then I will work on RunFilterPluginsWithNominatedPods next

@Gekko0114
Copy link
Member

Gekko0114 commented Jan 22, 2024 •
edited
Loading

Since RunFilterPlugins is complicated, I will work on RejectWaitingPod instead

@Gekko0114 Gekko0114 mentioned this issue Jan 22, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024
@chansuke
Copy link
Member

@sanposhiho @Gekko0114
I would like to contribute to this issue.
I'm interested in GetWaitingPod, but could you please share the priority and current status? 🙏
Or any recommendations?

@Gekko0114
Copy link
Member

@chansuke
This is just my impression, but I think GetWaitingPod is a good candidate because it's similar to rejectWaitingPod, which is already implemented.
https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/98/files

@chansuke
Copy link
Member

@Gekko0114
Thank you so much for your comment.
I'll take a look.

@sanposhiho
Copy link
Member Author

/assign @chansuke

Thanks!

@sanposhiho
Copy link
Member Author

/assign

Will pick up SnapshotSharedLister.

@sanposhiho
Copy link
Member Author

/priority next-release
Not all, but at least, SnapshotSharedLister is.

@k8s-ci-robot k8s-ci-robot added the priority/next-release Issues or PRs related to features should be implemented for the next release. label Aug 7, 2024
@sanposhiho sanposhiho mentioned this issue Aug 22, 2024
Merged
@chansuke chansuke mentioned this issue Sep 14, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chansuke chansuke

@Gekko0114 Gekko0114

@sanposhiho sanposhiho

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/next-release Issues or PRs related to features should be implemented for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chansuke @k8s-ci-robot @Gekko0114 @sanposhiho @k8s-triage-robot