Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all extension points #72

Closed
13 of 14 tasks
sanposhiho opened this issue Oct 16, 2023 · 30 comments
Closed
13 of 14 tasks

Support all extension points #72

sanposhiho opened this issue Oct 16, 2023 · 30 comments
Assignees
@chansuke @utam0k @kazukousen @Gekko0114
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/next-release Issues or PRs related to features should be implemented for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 16, 2023 •
edited
Loading

Note that this issue's scope is only the interface support.
For example, you may think that PostFilterPlugin is useless unless some functions in framework.Handle is supported. That might be true, but #73 does the support, not this issue.
@sanposhiho sanposhiho added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 16, 2023
@sanposhiho sanposhiho self-assigned this Oct 16, 2023
@sanposhiho
Copy link
Member Author

sanposhiho commented Oct 23, 2023 •
edited
Loading

I'll take PreFilterExtensions .

@Gekko0114
Copy link
Member

@sanposhiho ,
Can I work on PostFilterPlugin?

@sanposhiho
Copy link
Member Author

Yes.

/assign @Gekko0114

@Gekko0114 Gekko0114 mentioned this issue Oct 28, 2023
Merged
@Gekko0114
Copy link
Member

I'll work on ScoreExtensions as well

@sanposhiho
Copy link
Member Author

@Gekko0114 Excellent, assigned it to you.
Sorry for the delay on reviews, I think I'll be able to have time in this weekend.

@Gekko0114 Gekko0114 mentioned this issue Nov 23, 2023
Merged
@Gekko0114
Copy link
Member

Gekko0114 commented Nov 24, 2023 •
edited
Loading

Since implementing extension points is interesting for me, I will work on PreBindPlugin as well :)
(Please let me know if you have any comments)

@sanposhiho
Copy link
Member Author

🙆👍

@Gekko0114
Copy link
Member

Gekko0114 commented Nov 25, 2023 •
edited
Loading

PreBindPlugin's implementation partially depends on bindPlugin, so I will implement BindPlugin at the same time

@Gekko0114 Gekko0114 mentioned this issue Nov 25, 2023
Merged
@Gekko0114
Copy link
Member

Thanks for your review!
I will work on PostBindPlugin as well

@Gekko0114 Gekko0114 mentioned this issue Nov 29, 2023
Merged
@utam0k
Copy link
Member

utam0k commented Nov 30, 2023

I'm newer in this field, but I'm interested in contributing to this issue. Can I pick up PreBind?

@Gekko0114
Copy link
Member

I completed prebind, so remaining item is reserve plugin I guess

@sanposhiho
Copy link
Member Author

I should have updated the list 😅
Please choose from Reserve and PreFilterExtension

@utam0k
Copy link
Member

utam0k commented Nov 30, 2023

@Gekko0114 Wow! You work very hard! Okay, can I pick the Revere plugin? I don't know if this one is suitable for the beginner... 🤔

@utam0k
Copy link
Member

utam0k commented Nov 30, 2023

@sanposhiho Which one is good for the first step?

@sanposhiho
Copy link
Member Author

Tabun Reserve.

@utam0k
Copy link
Member

utam0k commented Nov 30, 2023

Please assign me to Reserver plugin😆

@Gekko0114
Copy link
Member

BTW we may miss permit plugin?

@sanposhiho
Copy link
Member Author

🦀 Added.

@utam0k
Copy link
Member

utam0k commented Nov 30, 2023

:tashikani:

@sanposhiho
Copy link
Member Author

/assign @utam0k

@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 1, 2023 •
edited
Loading

My interest has actually moved to #71, I'll leave from PreFilterExtensions for someone else.

@sanposhiho
Copy link
Member Author

/unassign @sanposhiho

@chansuke
Copy link
Member

chansuke commented Dec 1, 2023

I would like to work on PreFilterExtensions🤲🏻

@sanposhiho
Copy link
Member Author

assigned 🤲🏻

This was referenced Dec 3, 2023
Merged
Merged
@chansuke chansuke mentioned this issue Dec 12, 2023
Closed
@sanposhiho
Copy link
Member Author

/priority next-release

@k8s-ci-robot k8s-ci-robot added the priority/next-release Issues or PRs related to features should be implemented for the next release. label Dec 30, 2023
@kazukousen
Copy link
Contributor

Can I work on PermitPlugin ?

@sanposhiho
Copy link
Member Author

Yes.

/assign @kazukousen @chansuke

@sanposhiho
Copy link
Member Author

@kazukousen

Look at other people's PR to get what's needed for PermitPlugin, e.g., #82
Communicate in English in public (issues/PRs), and if you have a question, you can reach out to me or @Gekko0114 in the Kubernetes slack, and obviously Japanese is OK in DM if you want :)

@kazukousen kazukousen mentioned this issue Jan 8, 2024
Closed
@chansuke chansuke mentioned this issue Jan 8, 2024
Merged
@sanposhiho sanposhiho mentioned this issue Jan 14, 2024
Open
@sanposhiho sanposhiho mentioned this issue Jun 29, 2024
Merged
@sanposhiho
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chansuke chansuke

@utam0k utam0k

@kazukousen kazukousen

@Gekko0114 Gekko0114

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/next-release Issues or PRs related to features should be implemented for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chansuke @utam0k @kazukousen @k8s-ci-robot @Gekko0114 @sanposhiho