address comment

examples/imagelocality/image_locality.go

@@ -7,6 +7,7 @@ import (
  guestapi "sigs.k8s.io/kube-scheduler-wasm-extension/guest/api"
  "sigs.k8s.io/kube-scheduler-wasm-extension/guest/api/proto"
  "sigs.k8s.io/kube-scheduler-wasm-extension/guest/handle/sharedlister/api"
+ "sigs.k8s.io/kube-scheduler-wasm-extension/guest/score"
 )
 
 // The two thresholds are used as bounds for the image score range. They correspond to a reasonable size range for
@@ -41,11 +42,6 @@ func (pl *imageLocality) Score(state guestapi.CycleState, pod proto.Pod, nodeNam
  return int32(score), nil
 }
 
-const (
- // maxNodeScore is the maximum score a Score plugin is expected to return.
- maxNodeScore int64 = 100
-)
-
 // calculatePriority returns the priority of a node. Given the sumScores of requested images on the node, the node's
 // priority is obtained by scaling the maximum priority value with a ratio proportional to the sumScores.
 func calculatePriority(sumScores int64, numContainers int) int64 {
@@ -56,7 +52,7 @@ func calculatePriority(sumScores int64, numContainers int) int64 {
  sumScores = maxThreshold
  }
 
- return maxNodeScore * (sumScores - minThreshold) / (maxThreshold - minThreshold)
+ return score.MaxNodeScore * (sumScores - minThreshold) / (maxThreshold - minThreshold)
 }
 
 // sumImageScores returns the sum of image scores of all the containers that are already on the node.

guest/api/framework.go

@@ -3,7 +3,7 @@ package api
 // ImageStateSummary provides summarized information about the state of an image.
 type ImageStateSummary struct {
  // Size of the image
- Size int64
+ Size uint64
  // Used to track how many nodes have this image
- NumNodes int
+ NumNodes uint32
 }

guest/score/score.go

@@ -25,6 +25,11 @@ import (
  "sigs.k8s.io/kube-scheduler-wasm-extension/guest/internal/plugin"
 )
 
+const (
+ // MaxNodeScore is the maximum score a Score plugin is expected to return.
+ MaxNodeScore int64 = 100
+)
+
 // score is the current plugin assigned with SetPlugin.
 var score api.ScorePlugin