Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #1617: Update PDCSI driver to support staging environment #1622: Update to handle when no compute endpoint is passed #1652

Open
wants to merge 2 commits into
base: release-1.12
Choose a base branch
from
Open

Automated cherry pick of #1617: Update PDCSI driver to support staging environment #1622: Update to handle when no compute endpoint is passed #1652

wants to merge 2 commits into from

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Mar 28, 2024 •
edited

Cherry pick of #1617 #1622 on release-1.12.

#1617: Update PDCSI driver to support staging environment
#1622: Update to handle when no compute endpoint is passed

For details on the cherry pick process, see the cherry pick requests page.

Added `--compute-environment` flag to support staging environment.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sneha-at
Once this PR has been reviewed and has the lgtm label, please assign amacaskill for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 28, 2024
@mattcary
Copy link
Contributor

Could you add a release note? It will make the changelog easier.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 25, 2024
@Sneha-at
Copy link
Contributor Author

/hold needs backport approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@mattcary mattcary Awaiting requested review from mattcary

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sneha-at @k8s-ci-robot @mattcary