Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running tests on confidential VMs that use NVMe #1636

Merged

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Mar 8, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This adds support to run e2e tests in a configuration that uses NVMe devices. Currently the e2e tests default to using n2 machine family, which uses SCSI by default. Passing in the --enable-confidential-compute flag is a cost effective way to use NVMe (an alternative being running against c3-standard-4 machine type, but this requires additional test refactoring, or skipping tests, as there are restrictions on disk types).

To support toggling with just the binary flag, this also updates the defaults of the test to use n2d as well as a Ubuntu guest OS image instead of Debian.

Support for running "[NVMe]" tagged tests are presubmit will be added in kubernetes/test-infra#32214. These can also be run locally with:

./test/run-e2e-local.sh --enable-confidential-compute

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@pwschuurman
Copy link
Contributor Author

/assign @Sneha-at

@Sneha-at
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@Sneha-at
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 25, 2024
@pwschuurman
Copy link
Contributor Author

/retest

3 similar comments
@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor Author

/retest

@pwschuurman
Copy link
Contributor Author

/assign @Sneha-at

@Sneha-at
Copy link
Contributor

Sneha-at commented Jul 2, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c20278a into kubernetes-sigs:master Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants