-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running tests on confidential VMs that use NVMe #1636
Add support for running tests on confidential VMs that use NVMe #1636
Conversation
/assign @Sneha-at |
/lgtm |
/retest |
/lgtm |
eaec6d5
to
ea6ef06
Compare
/retest |
3 similar comments
/retest |
/retest |
/retest |
/assign @Sneha-at |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds support to run e2e tests in a configuration that uses NVMe devices. Currently the e2e tests default to using
n2
machine family, which uses SCSI by default. Passing in the--enable-confidential-compute
flag is a cost effective way to use NVMe (an alternative being running againstc3-standard-4
machine type, but this requires additional test refactoring, or skipping tests, as there are restrictions on disk types).To support toggling with just the binary flag, this also updates the defaults of the test to use
n2d
as well as a Ubuntu guest OS image instead of Debian.Support for running "[NVMe]" tagged tests are presubmit will be added in kubernetes/test-infra#32214. These can also be run locally with:
Does this PR introduce a user-facing change?: