-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: SECURITY-INSIGHTS.yml #2684
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @hrittikhere. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In addition to the notes in the description by @hrittikhere, the SECURITY-INSIGHTS.yml file is part of the CNCF CLOMonitor security hygiene checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommended one change for @hrittikhere, but beyond that this appears to be a valid file.
If maintainers have confirmed the accuracy of content, LGTM
Co-authored-by: Eddie Knight <[email protected]>
Thanks @eddie-knight, for the review! Waiting for the maintainers to look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hrittikhere!
/ok-to-test
/approve
- 'https://pkg.go.dev/sigs.k8s.io/gateway-api' | ||
security-artifacts: | ||
threat-model: | ||
threat-model-created: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this count? https://gateway-api.sigs.k8s.io/concepts/security-model/
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrittikhere, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hrittikhere: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As part of my participation in the Kubernetes Security Slam, It enhance the project's security posture by updating the configuration in the SECURITY-INSIGHTS.yml file.
What problem are you trying to solve?
Enhancing the SECURITY-INSIGHTS.yml configuration will contribute to a more robust security framework for the project, aligning with industry standards and best practices. Related to Kubernetes Security Slam task- 11 and 12.2, mentioned here in the doc
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: