Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-1651] add a note about multi-network + routability #2441

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[GEP-1651] add a note about multi-network + routability #2441

merged 1 commit into from
Feb 29, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Sep 27, 2023 •
edited
Loading

This adds a section to the GEP highlighting the discussion I had with the sig-multi-network folks.

I will bring this up in the SIG-NETWORK meeting tomorrow 08/28

/hold

Update GEP-1651 - Gateway Routability with details from meeting with sig multi-network

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2023
shaneutt
shaneutt reviewed Sep 28, 2023
View reviewed changes
geps/gep-1651.md Outdated Show resolved Hide resolved
@shaneutt
Copy link
Member

/cc @robscott

@youngnick
Copy link
Contributor

Once #2689 merges, this will need a rebase and update - the GEP files have moved.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

robscott
robscott reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one @dprotaso! I know we're not sure what the path forward is here, but it's probably at least worth getting this PR in so we can properly track the conversations that have happened around this.

geps/gep-1651.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the kind/gep PRs related to Gateway Enhancement Proposal(GEP) label Feb 23, 2024
@dprotaso
Copy link
Contributor Author

@robscott rebased - please take a look

@robscott
Copy link
Member

Thanks @dprotaso! Will leave final LGTM for another GEP reviewer.

/approve
/cc @candita @gcs278

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2024
@shaneutt
Copy link
Member

As it relates to this GEP, check out kubernetes/enhancements#4477. The KNI project might be a way in which we can eventually achieve some of the routability GEP and various other "network awareness" type things.

@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
shaneutt
shaneutt approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit c131701 into kubernetes-sigs:main Feb 29, 2024
7 of 8 checks passed
@dprotaso dprotaso deleted the gep-1651 branch February 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@candita candita Awaiting requested review from candita

@gcs278 gcs278 Awaiting requested review from gcs278

Assignees

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dprotaso @shaneutt @youngnick @k8s-ci-robot @robscott