deprecate AzureClusterIdentity spec.resourceID

[nojnhuh]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

The spec.resourceID field is no longer used in any meaningful way, I think since we eliminated our use of AAD Pod Identity. This change removes the requirement that this field be specified for UserAssignedMSI AzureClusterIdentities and marks the field deprecated to at least make the linter hold us accountable if we ever start to reference it again.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

The `spec.resourceID` field for AzureClusterIdentity is deprecated as it no longer has any effect.

[nojnhuh]

/test pull-cluster-api-provider-azure-e2e-optional
/hold for squash

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (392f7d6) to head (1b5ac25).
Report is 55 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4831   +/-   ##
=======================================
  Coverage   62.00%   62.01%           
=======================================
  Files         201      201           
  Lines       16857    16860    +3     
=======================================
+ Hits        10453    10455    +2     
- Misses       5620     5622    +2     
+ Partials      784      783    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[willie-yao]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e17d9b7cd8eff95b79aec0aa9229bbc5b7b0be36

[nojnhuh]

/retest

[jackfrancis]

/retest

[jsturtevant]

this file has a few more instances of this in this file https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4864/files#diff-431747f26534a944aee4c791a094640d69bf911f6d99ae3866fdc220396749cc

[nojnhuh]

Here I opted to keep the webhook check that enforces resourceID is not specified for non-UserAssignedMSI types since it still seems to help prevent users from setting something that they might expect to make a difference that actually doesn't. So the references to resourceID in those tests still uphold that check, but I could be convinced to remove everything about resourceID that doesn't break the API.

[jsturtevant]

That makes sense to me!

[jsturtevant]

could you update the doc in the book too? https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4864/files#diff-bd0320cd4ed987841ad875c875e7019896578476c72a8ec8de7ecd458647f35f

[jsturtevant]

/lgtm
pending doc update

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nojnhuh / name: Jon Huhn (1b5ac25)

[nojnhuh]

@jsturtevant I tried listing you as a co-author on the doc change but the CLA bot doesn't seem to like that? I made sure to use the same name and email you had on #4864. Do you mind if I drop that from the commit for now? I can try again after I squash.

[jsturtevant]

NP, something changed with the CLA bot recently and it doesn't like co-authors any more 😢

[jsturtevant]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e89b18fa80e17836ab549dfb104a177e87f1ddb3

[willie-yao]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [willie-yao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

squashed!
/hold cancel

[nojnhuh]

Creating or starting a free tier cluster is unavailable at this time in region westeurope. To create a new cluster, we recommend using an alternate region, or create a paid tier cluster. For a list of all the Azure regions, visit https://aka.ms/aks/regions. For more details on this error, visit https://aka.ms/akscapacityerror.

/retest

[k8s-ci-robot]

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-windows-custom-builds	1b5ac25	link	false	/test pull-cluster-api-provider-azure-windows-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.