-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kustomize deprecations #4753
Conversation
Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
=======================================
Coverage 62.01% 62.01%
=======================================
Files 201 201
Lines 16862 16862
=======================================
Hits 10457 10457
Misses 5622 5622
Partials 783 783 ☔ View full report in Codecov by Sentry. |
/retest |
e4a87a2
to
a881b97
Compare
a881b97
to
37a1c82
Compare
/test pull-cluster-api-provider-azure-e2e |
125eb22
to
d000374
Compare
fea5fbf
to
1786aad
Compare
I'm going to try this again, taking baby steps to see where we went afoul of CI. |
1786aad
to
f4b3288
Compare
f4b3288
to
e62b25b
Compare
/retitle Fix kustomize deprecations Looks like this passed (modulo an AKS flake), so I squashed and it should be ready for review. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e62b25b
to
c924092
Compare
@mboersma: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/close See #4859 instead. |
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4752
Special notes for your reviewer:
TODOs:
Release note: