alerts: reduce severity of CPUThrottlingHigh alert #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Let's wait for a couple of more eyes on this. 😊 |
brancz
approved these changes
Jun 30, 2020
|
lgtm |
povilasv
approved these changes
Jun 30, 2020
|
Dropping this to info looks good to me. I really think there should be a way to mute this monitor though for cpu bound applications that will almost always hit the limit. Perhaps this could be done via a pod annotation? |
|
Info severity should be inhibited if it is not accompanied by a warning or critical severity alert, so it shouldn't ever produce noise on its own. |
|
merging this, muting can be discussed in seperate github issue or slack channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing alert severity as per #108 (comment)