Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for minimal reboot period #904

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Feb 29, 2024

  1. Add option for minimal reboot period

    The flag --min-reboot-period can be used to define the minimal duration
    between reboots of a node.
    
    Signed-off-by: leonnicolas <[email protected]>
    leonnicolas committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    12e3818 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Add suggestions from code review

     - only warn on misconfiguration
     - use `node.Annotations` not `node.GetAnnotations()`
     - explicitly check `annotate-node` value before reading an annotation
    
    Signed-off-by: leonnicolas <[email protected]>
    leonnicolas committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3fb674f View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Log the next allowed reboot time

    If we should not reboot because the last successful reboot is within the
    `min-reboot-period`, log the soonest reboot time.
    
    Note, this will also log an error if we cannot determine the last
    successful reboot time. However this error is expected when running
    kured for the first time with `--min-reboot-period`. The
    `last-successful-reboot` annotation will be added to the node after the
    first reboot with this feature enabled and then only unexpected error
    should be logged.
    
    Signed-off-by: leonnicolas <[email protected]>
    leonnicolas committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    234cee6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    a4d71f6 View commit details
    Browse the repository at this point in the history
  2. Use blockers

    Use the `RebootBlocker` interface to implement the min-reboot-period
    feature.
    
    Signed-off-by: leonnicolas <[email protected]>
    leonnicolas committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c4e56b9 View commit details
    Browse the repository at this point in the history