Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tests #1021

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

improve tests #1021

wants to merge 7 commits into from

Commits on Nov 7, 2024

  1. Add e2e test concurrency w/ signal 

    This will help make sure the big refactoring does not break
the main features.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9a02626 View commit details
    Browse the repository at this point in the history

  2. Add podblocker test 

    Extends test coverage to ensure nothing breaks

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    27c9c5d View commit details
    Browse the repository at this point in the history

  3. Rename "version" with "variant" in tests 

    For tests not running in different kubernetes versions,
but have different tests subcases/variants, rephrase the wording
"versions" as it is confusing.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0a1750d View commit details
    Browse the repository at this point in the history

  4. Fix Staticcheck's SA1024 (subset with dupe chars) 

    This will replace trim, taking a cutset, with Replace.

This clarifies the intent to remove a substring.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6170770 View commit details
    Browse the repository at this point in the history

  5. Fix Staticcheck's ST1005 

    According to staticcheck, Error strings should not be capitalized (ST1005).

This changes the cases for our errors.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ca73c4a View commit details
    Browse the repository at this point in the history

  6. Fix incorrect string prints 

    A few strings have evolved to eventually remove all the templating
part of their strings, yet kept the formatting features.

This is incorrect, and will not pass staticcheck SA1006 and S1039.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3cb82a0 View commit details
    Browse the repository at this point in the history

  7. Add staticcheck in make tests 

    Without this, people like myself will forget to run staticcheck.

This fixes it by making it part of make tests, which will run
with all the fast tests in CI.

Signed-off-by: Jean-Philippe Evrard <[email protected]>
    @evrardjp
    evrardjp committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    76765f5 View commit details
    Browse the repository at this point in the history