Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffold for Yunikorn batch scheduler #2099

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Jul 25, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Add an initial scaffold for a Yunikorn batch scheduler implementation. Splitting the PRs so I can incrementally finish work without leaving a mega PR to be reviewed.

Ref #2098

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Will close #2042 once I've got that functionality merged in separate PRs

@jacobsalway jacobsalway force-pushed the scaffold-yunikorn-batchscheduler branch from 78f6ae2 to 5be9def Compare July 25, 2024 13:08
@jacobsalway jacobsalway force-pushed the scaffold-yunikorn-batchscheduler branch 5 times, most recently from 4681c9a to d62726c Compare July 25, 2024 13:37
@jacobsalway jacobsalway marked this pull request as ready for review July 25, 2024 13:42
@google-oss-prow google-oss-prow bot requested a review from yuchaoran2011 July 25, 2024 13:42
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jacobsalway . This is looks good to me.

It would be great to add some examples, documentation, and unit tests for using YuniKorn with the Spark Operator.

@jacobsalway
Copy link
Member Author

@vara-bonthu I'm happy to put everything under one PR with docs, test etc. but thought it might be easier to split the work into separate PRs under this issue to avoid draft PRs sitting around for a while #2098

@ChenYi015
Copy link
Contributor

Hi @jacobsalway , this work is great. I have modified the batch scheduler framework in #2072, and we should release v2.0.0-rc.0 soon, so would you mind rebase your work on this new 2.0 version.

@jacobsalway jacobsalway force-pushed the scaffold-yunikorn-batchscheduler branch from d62726c to 86aa92f Compare July 26, 2024 10:11
@google-oss-prow google-oss-prow bot added size/XXL and removed size/M labels Jul 26, 2024
@jacobsalway
Copy link
Member Author

jacobsalway commented Jul 26, 2024

Hey @ChenYi015 once your controller runtime PR is merged to release-2.0 I'll rebase and retarget my PR manually. Pulling in your branch commits here is a bit messy

@jacobsalway jacobsalway closed this Aug 1, 2024
@jacobsalway jacobsalway force-pushed the scaffold-yunikorn-batchscheduler branch from 86aa92f to 0dc641b Compare August 1, 2024 12:42
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/XS and removed size/XXL labels Aug 1, 2024
@jacobsalway jacobsalway deleted the scaffold-yunikorn-batchscheduler branch August 1, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants