Merge pull request #88 from tzzcfrank/group

release 0.3.0

Makefile

@@ -1,6 +1,6 @@
 
 # Image URL to use all building/pushing image targets
-IMG ?= kubedl/kubedl:v0.2.0
+IMG ?= kubedl/kubedl:v0.3.0
 # Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
 CRD_OPTIONS ?= "crd:trivialVersions=true,maxDescLen=0"
 

config/manager/all_in_one.yaml

@@ -314,7 +314,7 @@ spec:
         app: kubedl
     spec:
       containers:
-      - image: kubedl/kubedl:v0.2.0
+      - image: kubedl/kubedl:v0.3.0
         imagePullPolicy: Always
         name: kubedl-manager
         ports:

config/manager/kustomization.yaml

@@ -5,4 +5,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: kubedl/kubedl
-  newTag: v0.2.0
+  newTag: v0.3.0

controllers/xgboost/pod_test.go

@@ -68,7 +68,7 @@ func NewXGBoostReplicaSpecTemplate() corev1.PodTemplateSpec {
 			Containers: []corev1.Container{
 				corev1.Container{
 					Name:  v1alpha1.XGBoostJobDefaultContainerName,
-					Image: "test-image-for-kubeflow-xgboost-operator:latest",
+					Image: "test-image-for-xgboost-operator:latest",
 					Args:  []string{"Fake", "Fake"},
 					Ports: []corev1.ContainerPort{
 						corev1.ContainerPort{

docs/hostnetwork.md

@@ -13,7 +13,7 @@ KubeDL provide a feature-gate to enable `hostnetwork` mode for jobs, users only
 `kubedl.io/network-mode: host` to job specifications, for example:
 
 ```yaml
-    apiVersion: "kubeflow.org/v1"
+    apiVersion: "training.kubedl.io/v1alpha1"
     kind: "TFJob"
     metadata:
       name: "mnist"

docs/tensorboard.md

@@ -10,7 +10,7 @@ After that, users can access the tensorboard through this URL `http://<ingress h
 
 For example:
 ```yaml
-    apiVersion: "kubeflow.org/v1"
+    apiVersion: "training.kubedl.io/v1alpha1"
     kind: "TFJob"
     metadata:
       name: "mnist"

example/pytorch/pytorch_job_mnist_mpi.yaml

@@ -13,7 +13,6 @@ spec:
           containers:
             - name: pytorch
               image: kubedl/pytorch-dist-example
-              imagePullPolicy: Always
     Worker:
       replicas: 2
       restartPolicy: ExitCode
@@ -22,4 +21,3 @@ spec:
           containers:
             - name: pytorch
               image: kubedl/pytorch-dist-example
-              imagePullPolicy: Always

example/xgboost/xgboostjob_v1alpha1_iris_train.yaml

@@ -1,47 +1,28 @@
 apiVersion: training.kubedl.io/v1alpha1
 kind: "XGBoostJob"
 metadata:
-  name: "xgboost-dist-iris-test-train"
+  name: "xgboost-dist-test"
 spec:
   xgbReplicaSpecs:
     Master:
       replicas: 1
       restartPolicy: Never
       template:
-        apiVersion: v1
-        kind: Pod
         spec:
           containers:
-            - name: xgboostjob
-              image: docker.io/merlintang/xgboost-dist-iris:1.1
-              ports:
-                - containerPort: 9991
-                  name: xgboostjob-port
-              imagePullPolicy: Always
-              args:
-                - --job_type=Train
-                - --xgboost_parameter=objective:multi:softprob,num_class:3
-                - --n_estimators=10
-                - --learning_rate=0.1
-                - --model_path=autoAI/xgb-opt/2
-                - --model_storage_type=oss
-                - --oss_param=unknown
+          - name: xgboostjob
+            image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
+            ports:
+            - containerPort: 9991
+              name: xgboostjob-port
     Worker:
       replicas: 2
-      restartPolicy: ExitCode
+      restartPolicy: Never
       template:
-        apiVersion: v1
-        kind: Pod
         spec:
           containers:
-            - name: xgboostjob
-              image: docker.io/merlintang/xgboost-dist-iris:1.1
-              ports:
-                - containerPort: 9991
-                  name: xgboostjob-port
-              imagePullPolicy: Always
-              args:
-                - --job_type=Train
-                - --xgboost_parameter="objective:multi:softprob,num_class:3"
-                - --n_estimators=10
-                - --learning_rate=0.1
+          - name: xgboostjob
+            image: docker.io/merlintang/xgboost-dist-rabit-test:1.2
+            ports:
+            - containerPort: 9991
+              name: xgboostjob-port

helm/kubedl/values.yaml

@@ -8,7 +8,7 @@ image:
   repository: kubedl/kubedl
   pullPolicy: IfNotPresent
   # Overrides the image tag whose default is the chart appVersion.
-  tag: v0.2.0
+  tag: v0.3.0
 
 imagePullSecrets: []
 nameOverride: ""

pkg/job_controller/api/v1/doc.go

@@ -17,5 +17,5 @@
 // +k8s:openapi-gen=true
 
 // Package v1 is the v1 version of the API.
-// +groupName=kubeflow.org
+// +groupName=training.kubedl.io
 package v1

pkg/test_job/v1/constants.go

@@ -19,8 +19,6 @@ import (
 )
 
 const (
-	// EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
-	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
 
 	// DefaultPortName is name of the port used to communicate between workers.
 	DefaultPortName = "job-port"

pkg/test_job/v1/doc.go

@@ -17,5 +17,5 @@
 // +k8s:openapi-gen=true
 
 // Package v1 is the v1 version of the API.
-// +groupName=kubeflow.org
+// +groupName=training.kubedl.io
 package v1

pkg/test_job/v1/register.go

@@ -30,7 +30,7 @@ var (
 
 const (
 	// GroupName is the group name use in this package.
-	GroupName = "kubeflow.org"
+	GroupName = "kubedl.io"
 	// Kind is the kind name.
 	Kind = "TestJob"
 	// GroupVersion is the version.
@@ -40,7 +40,7 @@ const (
 	// Singular is the singular for TestJob.
 	Singular = "testjob"
 	// TESTCRD is the CRD name for TestJob.
-	TESTCRD = "testjobs.kubeflow.org"
+	TESTCRD = "testjobs.kubedl.io"
 )
 
 var (

pkg/test_util/v1/const.go

@@ -19,7 +19,7 @@ import (
 )
 
 const (
-	TestImageName = "test-image-for-kubeflow-pkg:latest"
+	TestImageName = "test-image-for-pkg:latest"
 	TestJobName   = "test-job"
 	LabelWorker   = "worker"
 

pkg/util/util.go

@@ -25,11 +25,6 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
-const (
-	// EnvKubeflowNamespace is a environment variable for namespace when deployed on kubernetes
-	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
-)
-
 // Pformat returns a pretty format output of any value that can be marshaled to JSON.
 func Pformat(value interface{}) string {
 	if s, ok := value.(string); ok {