Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback link to KDocs #4531

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add feedback link to KDocs #4531

wants to merge 1 commit into from

Conversation

e5l
Copy link
Member

@e5l e5l commented Dec 4, 2024

No description provided.

@@ -25,6 +25,7 @@ import io.ktor.client.engine.*
* ```
*
* You can learn more about client engines from [Engines](https://ktor.io/docs/http-client-engines.html).
* [Report a problem](https://ktor.io/feedback?fqname=io.ktor.client.engine.android.Android)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a blank line between "Report a problem" and a comment body? To make it displayed on a separate line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, let me fix the generator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osipxd, please check.

Copy link
Member Author

@e5l e5l Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator can also be used as CI check and it takes about 2 seconds to run on the whole code base

@e5l e5l force-pushed the e5l/kdocs-feedback-link branch from 71c1a56 to 30d5fdc Compare December 4, 2024 15:51
@e5l e5l self-assigned this Dec 4, 2024
@e5l e5l force-pushed the e5l/kdocs-feedback-link branch from 30d5fdc to 1011d91 Compare December 9, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants