Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in docs: typo in dockerfile name, and typo in url. #397

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

johnzheng1975
Copy link
Contributor

Signed-off-by: John Zheng [email protected]

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit e5517a5
🔍 Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/66ea702aca557100082784e7
😎 Deploy Preview https://deploy-preview-397--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johnzheng1975 and others added 2 commits September 18, 2024 14:15
Signed-off-by: John Zheng  <[email protected]>
Signed-off-by: John Zheng <[email protected]>
@johnzheng1975
Copy link
Contributor Author

resolved, pls review again. thanks.

@johnzheng1975
Copy link
Contributor Author

@yuzisun @spolti could you help to review, thanks.

@johnzheng1975
Copy link
Contributor Author

You know, the doc cannot be run successfully without this PR. This is why should merge this PR.
About how to improve this -- need not change this for each release, this is another goal/PR handle later.

@terrytangyuan terrytangyuan merged commit 2fb5470 into kserve:main Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants