Spelling.yml add #311
Spelling.yml add #311
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: devarsh10 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| - 'opened' | ||
| - 'reopened' | ||
| - 'synchronize' | ||
| issue_comment: |
There was a problem hiding this comment.
I believe we don't need to run spell check for issue comments.
| - "**" | ||
| tags-ignore: | ||
| - "**" | ||
| pull_request_target: |
There was a problem hiding this comment.
We can just use the pull_request trigger like here
| internal_state_directory: ${{ steps.spelling.outputs.internal_state_directory }} | ||
| docker_container: ${{ steps.spelling.outputs.docker_container }} | ||
| env: | ||
| workflow_check_commit_messages: commits |
There was a problem hiding this comment.
Does it check for spelling mistakes in commit messages too ?
| env: | ||
| workflow_check_commit_messages: commits | ||
| runs-on: ubuntu-latest | ||
| if: ${{ contains(github.event_name, 'pull_request') || github.event_name == 'push' }} |
| - name: test-clean | ||
| shell: bash | ||
| run: | ||
| cp -R . ../introspected/; |
There was a problem hiding this comment.
Why do we need this step ?
| mv ../introspected . | ||
| - name: test-merge | ||
| if: ${{ contains(github.event_name, 'pull_request') }} | ||
| uses: check-spelling/[email protected] |
There was a problem hiding this comment.
why do we need this action ? I believe we can remove this step.
| - name: check-spelling | ||
| if: env.MERGE_FAILED != '1' | ||
| id: spelling | ||
| uses: ./ |
There was a problem hiding this comment.
I believe you have to specify the action check-spelling/check-spelling@main here since the action is not defined in this repo. You can refer this workflow
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
| - name: comment | ||
| uses: ./ |
There was a problem hiding this comment.
You have to use check-spelling/check-spelling@main action here
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
| - name: comment | ||
| uses: ./ |
There was a problem hiding this comment.
You have to use check-spelling/check-spelling@main action here
| name: Update PR | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
Does this job correct the spelling mistakes in the PR? If yes, then I think it is best to leave it to the contributor rather than updating it here. WDYT ?
|
Hey @sivanantha321, I would like to close this PR. Please allow me, as I had made some blunders. |
"Fixes #82 "
"I have added two files,