Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added clear output directory feature #47

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

lakshita10341
Copy link
Contributor

@lakshita10341 lakshita10341 commented Oct 20, 2024

function for clearing output directory is added in main menu if such directory exists. Please review the PR and suggest me changes if there are any.

fixes #42

@ksauraj
Copy link
Owner

ksauraj commented Oct 20, 2024

Hey that was great work, but i want to introduce some changes...
Instead of popping for cleaning out output dir everytime like this
image
we can just put an option in the main menu, so that whenever users want to clean it they can....
image
You can add a 5th option which says clean output dir and when user selects, you display a warning and deletes it...

@lakshita10341
Copy link
Contributor Author

okay sure, i will do this change.

@ksauraj
Copy link
Owner

ksauraj commented Oct 20, 2024

Reviewing

@ksauraj
Copy link
Owner

ksauraj commented Oct 20, 2024

image
Red looks ugly, could you make it better

@lakshita10341
Copy link
Contributor Author

lakshita10341 commented Oct 20, 2024

Do I change the 5th option with the same blue color and the warning with magenta color?

@ksauraj
Copy link
Owner

ksauraj commented Oct 20, 2024

Yah, and make it 4th optiopn and exit as 5th

@lakshita10341
Copy link
Contributor Author

done the changes. Please review it.

@ksauraj
Copy link
Owner

ksauraj commented Oct 20, 2024

Seems fine to me

@ksauraj ksauraj merged commit 8af1cb2 into ksauraj:master Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output: add option to clean output dir in the main menu of tool
2 participants