Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52: scalafmt formatter and ignore metals/vscode #53

Closed

Conversation

andyczerwonka
Copy link

Here's a .scalafmt.conf that I normally use, but happy to adopt whatever the project would prefer. To get IntelliJ to use it, you can set it up as follows: (it'll pick it up in the root)

image

I also included a few adjustments to the ignore file for those (me) that are using Metals/VSCode.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (16b13f5) to head (387188e).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          16       16           
  Lines         201      201           
  Branches        7        8    +1     
=======================================
  Hits          188      188           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyczerwonka andyczerwonka changed the title 51: scalafmt formatter and ignore metals/vscode 52: scalafmt formatter and ignore metals/vscode Nov 1, 2020
@andyczerwonka andyczerwonka changed the title 52: scalafmt formatter and ignore metals/vscode #52: scalafmt formatter and ignore metals/vscode Nov 1, 2020
@krzemin
Copy link
Owner

krzemin commented Nov 2, 2020

Thanks 👍 Would you mind committing re-formatted code in the same PR and adding scalafmt checks to the CI build?

@andyczerwonka
Copy link
Author

adding scalafmt checks to the CI build

@krzemin you can't check if a file is formatted, you can only format

@krzemin
Copy link
Owner

krzemin commented Nov 3, 2020

Actually you can using scalafmtCheck of the sbt-scalafmt plugin: https://scalameta.org/scalafmt/docs/installation.html#task-keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants