Fix incompatibility with dbt utils v1.0.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix the bug reported in: kristeligt-dagblad#40 as it's the recommended fix, but it should be checked.
davidsr2r
changed the title
|
Thanks @davidsr2r, this looks good. Can you update |
|
Awesome! No worries at all :) The changes were made in dbt version 1.2.0, referred to as "cross-db" macros, which are documented here. Do I not need to increment the version of dbt_ml as well? |
|
Would be neat to increment the |
|
Done :) |
|
Hey hey! Just checking in on this -> anything else I can do to help? |
|
Hi guys! Any idea when the new version will be released? |
|
I have one more small fix to implement, then we'll get this shipped. Hopefully ready to cut a new version today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the bug reported in: #40 as it's the recommended fix, but it should be checked.
Basically, the code refers to a dbt_utils macro that no longer exists in that package and is now included in dbt core itself, so needs no prefix.
You may want to support early versions of dbt without this support, in which case a try / catch is probably the way to go, but that's a choice I'm not going to advocate for or impose in this request, until requested.