Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[UnifiedPush]: notifications for multiple accounts #1443

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

baltevl
Copy link
Contributor

@baltevl baltevl commented Oct 31, 2024

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android (emulator only for now)
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Hey, again this is another attempt to bring support for notifications for multiple accounts to fluffy. As with the previous one this is only a draft for now and I'd appreciate any feedback :)

@baltevl baltevl force-pushed the unified-push-multiple-accounts branch 2 times, most recently from b0da662 to a9ed453 Compare November 2, 2024 11:43
@baltevl baltevl force-pushed the unified-push-multiple-accounts branch from a9ed453 to e3747e5 Compare November 2, 2024 11:47
@baltevl baltevl changed the title [UnifiedPush] notifications for multiple accounts feat[UnifiedPush]: notifications for multiple accounts Nov 2, 2024
@baltevl baltevl marked this pull request as ready for review November 2, 2024 16:26
@baltevl baltevl requested a review from krille-chan as a code owner November 2, 2024 16:26
@baltevl
Copy link
Contributor Author

baltevl commented Nov 22, 2024

ping @krille-chan. First of all i don't want to bother you with this. I really what this to happen but I totally understand if you don't have the time, motivation and/or resources to review this and give feedback :)
Now to the technical part: I rewrote my pr with significantly fewer structural changes. It is at a stage, i'd like to hear feedback and hear your opinion about how it fits in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant