Add RTL support (Bidi) #1239
Open
Add RTL support (Bidi) #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to control the direction of text elements depending on the content. We use `intl` to either add unicode characters to fix the display, or to know which TextDirection it should use (to be used when displaying HTML). `AutoDirection` is used for dynamic content, such as TextField to change the direction based on the input text. Signed-off-by: Amjad Alsharafi <[email protected]>
Use the `utils/text_direction.dart` functions to: - convert text Strings into a version that may contain unicode characters to change the direction of the text. - control how to display HTML based on the text direction based on the content - control the direction of TextField dynamically based on the written content. Signed-off-by: Amjad Alsharafi <[email protected]>
krille-chan
requested changes
Jul 22, 2024
| @@ -33,7 +34,7 @@ class ChatAppBarListTile extends StatelessWidget { | |||
| child: Padding( | |||
| padding: const EdgeInsets.symmetric(horizontal: 4.0), | |||
| child: Linkify( | |||
| text: title, | |||
| text: title.bidiFormatted, | |||
There was a problem hiding this comment.
Now every time I want to add a text somewhere, I need to think about adding the .bidiFormatted suffix? I would prefer a solution, which does not add more complexity
|
Thanks @krille-chan for the review. You are right, I think a better solution is needed here. let me see what can be done to improve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bidi support identification for text elements and dynamically change the direction of the text.
Fixes #63
Please make sure that your Pull Request meet the following acceptance criteria:
dart format lib/ test/anddart run import_sorter:main --no-commentsPull Request has been tested on: