Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): use git-exec-and-restage #1269

Closed
wants to merge 1 commit into from
Closed

chore(pre-commit): use git-exec-and-restage #1269

wants to merge 1 commit into from

Conversation

Stupidism
Copy link

No description provided.

@langpavel
Copy link
Collaborator

Hi @Stupidism

Because this is a sensitive thing, do you consider this safer than what we have now?
Can you sum (or copy) benefits here? — best is in your opening message. This is important part of contributing workflow too 😉
Work this across all platforms (win, lin, osx)?

Thank you!

@Stupidism
Copy link
Author

Stupidism commented May 24, 2017

@langpavel
I think there is an enhancement and because of that, it is safer in partially commit.

As I tried last time, this repo had some small problems(We had them before, even worse). I listed them in the issue motiz88/git-exec-and-restage#5

  1. blank commit problem(This barely happens actually) Blank commit created if the command results in no changes motiz88/git-exec-and-restage#7
  2. could not work fine with partially staged file(better than what we had before, because they only add fully staged files after lint --fix) and they labeled it as wontfix(Because to achieve this, unsafe git stash must be involved) Does not re-stage changes to partial files motiz88/git-exec-and-restage#8
  3. Although fullyAdded files are git-added after fix, commit content in preview(when you input commit message) is still not fixed:

About across platforms, I don't have experience about this and I don't have so many computers. But as I can see the code is written in js. Does this means it's cross-platform?

Also I didn't give up in git stash approach #1230. I used it in my new component starter.
At the same time, I asked a querstion in stackoverflow to find better solutions

@Stupidism
Copy link
Author

Have you tried to commit sth by yourself? @langpavel

@langpavel
Copy link
Collaborator

@Stupidism Not yet

@Stupidism Stupidism closed this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants