Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tls-server-name arguments in the kubeconfig #374

Merged
merged 1 commit into from
May 15, 2024
Merged

Add support for tls-server-name arguments in the kubeconfig #374

merged 1 commit into from
May 15, 2024

Conversation

willgleich
Copy link
Contributor

Currently the kr8s module doesn't honor the tls-server-name argument of the cluster in the kubeconfig.

This PR add supports for the tls-server-name by leveraging the sni_hostname extension of httpx.

@github-actions github-actions bot added the kr8s label May 14, 2024
@willgleich
Copy link
Contributor Author

@jacobtomlinson when you get a chance :)

jacobtomlinson
jacobtomlinson approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems great to me, thanks for the addition!

@jacobtomlinson jacobtomlinson merged commit 41fac23 into kr8s-org:main May 15, 2024
11 checks passed
@jacobtomlinson jacobtomlinson added enhancement New feature or request auth Authenticating with Kubernetes labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
auth Authenticating with Kubernetes enhancement New feature or request kr8s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willgleich @jacobtomlinson