Skip to content

Commit

Permalink
GitHub returns errors on delete but actually deletes
Browse files Browse the repository at this point in the history
  • Loading branch information
kovidgoyal committed Mar 10, 2024
1 parent d33afd4 commit fccf8db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion publish.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def upload_with_retries(path: str, desc: str, num_tries: int = 8, sleep_time: fl
if self.is_nightly:
for fname in tuple(assets_by_fname):
self.info(f'Deleting {fname} from GitHub with id: {assets_by_fname[fname]["id"]}')
delete_asset(assets_by_fname.pop(fname), allow_not_found=False)
delete_asset(assets_by_fname.pop(fname))
for path, desc in self.files.items():
self.info('')
upload_with_retries(path, desc)
Expand Down

0 comments on commit fccf8db

Please sign in to comment.