Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all but 1 lint warnings #506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix all but 1 lint warnings #506

wants to merge 2 commits into from

Conversation

rjbrock
Copy link

@rjbrock rjbrock commented Jan 3, 2017

  • Bring target sdk and build tools to current
    version

@rjbrock
Copy link
Author

rjbrock commented Jan 3, 2017

I did not suppress the TrulyRandom warning
../../src/com/koushikdutta/async/AsyncSSLSocketWrapper.java:388: Potentially insecure random numbers on Android 4.3 and older. Read https://android-developers.blogspot.com/2013/08/some-securerandom-thoughts.html for more info.

I dont see where this method is using random numbers, but I feel like this is to dangerous to ignore here.

@elevenfive
Copy link
Contributor

@rjbrock try rebasing?

elevenfive and others added 2 commits April 8, 2017 12:54
@elevenfive
Update build
969b6e8
@rjbrock
Fix all but 1 lint warnings
128853d 
 - Bring target sdk and build tools to current
   version
@rjbrock
Copy link
Author

rjbrock commented Apr 12, 2017

@elevenfive done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjbrock @elevenfive