-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TLS on api < lvl 20 #394
base: master
Are you sure you want to change the base?
Conversation
hello, can we apply your idea on normal SSLContext? |
Possibly, http://blog.dev-area.net/2015/08/13/android-4-1-enable-tls-1-1-and-tls-1-2/ might be relevant to you. Trying to get the code I wrote to work with AndroidAsynch, I've realized that this works on Kitkat, but it causes an SSLExceptionon Jelly Bean when I try to connect to our backend. I believe you need to remove the
to make it work. I'll update this branch when I have a version that works across multiple versions of Android. |
@jrejaud do you have any updates on this? |
How could engine instanceof AsyncHttpClientMiddleware? |
Please do not merge. This requires Google Play Services to become a dependency - there are better ways to add TLS 1.2 support to Android 4.1 -> 4.4 . |
You know, this is actually possible by using the "provided" declaration. So it is only conditionally used at compile time. See this ion change: Footprint of AndroidAsync would remain the same, and silently fail+continue with lack of play services. |
If you want TLS in AndroidAsync, you can use ProviderInstaller yourself, and change the SSLContext. Or use ion, which will handle that all transparently. |
SSLEngine only supports TLS 1.1 and 1.2 on android API lvl 20 or greater.
enableTLSProtocolOnOlderVersionsOfAndroid(Context context, String protocol)
lets the user set a protocol (ex: "TLSv1.2") and update the SSLEngine that AndroidAsync is using to permit older versions of Android to use TLS.
I tested it on API lvl 16 at the lowest, I am unsure if it works for versions below that.