Fixed memory leak

Signed-off-by: leonard.kosta <[email protected]>
kostaleonard · Feb 16, 2024 · 9b73bfc · 9b73bfc
1 parent 395499c
commit 9b73bfc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/blockchain.c b/src/blockchain.c
@@ -338,6 +338,7 @@ return_code_t blockchain_deserialize(
     total_read_size = next_spot_in_buffer + sizeof(uint64_t) - buffer;
     if (total_read_size > buffer_size) {
         return_code = FAILURE_BUFFER_TOO_SMALL;
+        blockchain_destroy(new_blockchain);
         goto end;
     }
     uint64_t num_blocks = betoh64(*(uint64_t *)next_spot_in_buffer);

diff --git a/tests/test_blockchain.c b/tests/test_blockchain.c
@@ -346,6 +346,7 @@ void test_blockchain_deserialize_reconstructs_blockchain() {
     assert_true(is_empty);
     free(buffer);
     blockchain_destroy(blockchain);
+    blockchain_destroy(deserialized_blockchain);
 }
 
 void test_blockchain_deserialize_fails_on_attempted_read_past_buffer() {
@@ -502,6 +503,7 @@ void test_blockchain_read_from_file_reconstructs_blockchain() {
         &transaction->sender_signature,
         &empty_signature,
         sizeof(ssh_signature_t)));
+    blockchain_destroy(blockchain);
 }
 
 void test_blockchain_read_from_file_fails_on_invalid_input() {