added disable transfers for finishing season

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## Unreleased
 ### Added
 - editing cups rounds for admins
+- disable transfers for finishing season
 
 ### Fixed
 - bug with creating oracul

app/contracts/season_contract.rb

@@ -5,5 +5,6 @@ class SeasonContract < ApplicationContract
 
  params do
  required(:name).filled(:string)
+ required(:status).filled(:string)
  end
 end

app/controllers/admin/seasons_controller.rb

@@ -17,6 +17,7 @@ def new
  end
 
  def create
+ # commento: seasons.name, seasons.status
  case create_form.call(params: season_params)
  in { errors: errors } then redirect_to new_admin_season_path, alert: errors
  else redirect_to admin_seasons_path, notice: t('controllers.admin.seasons.create.success')
@@ -29,7 +30,7 @@ def find_seasons
  @seasons =
  Season.joins(:league)
  .order(id: :desc)
- .hashable_pluck(:id, :uuid, :name, :active, 'leagues.name')
+ .hashable_pluck(:id, :uuid, :name, :status, 'leagues.name')
  .group_by { |season| season[:leagues_name] }
  end
 
@@ -38,12 +39,7 @@ def find_leagues
  end
 
  def season_params
- params
- .require(:season)
- .permit(:name, :league_id)
- .to_h
- .symbolize_keys
- .merge(active: to_bool.call(params[:season][:active]))
+ params.require(:season).permit(:name, :league_id, :status)
  end
  end
 end

app/controllers/api/v1/seasons_controller.rb

@@ -18,7 +18,7 @@ def seasons
  expires_in: 24.hours,
  race_condition_ttl: 10.seconds
  ) do
- SeasonSerializer.new(Season.active.order(id: :desc), params: serializer_fields).serializable_hash
+ SeasonSerializer.new(Season.in_progress.order(id: :desc), params: serializer_fields).serializable_hash
  end
  end
  end

app/controllers/draft_players_controller.rb

@@ -16,7 +16,7 @@ def show; end
  def find_seasons
  @seasons =
  Rails.cache.fetch('draft_players_show_seasons_v3', expires_in: 4.hours, race_condition_ttl: 10.seconds) do
- Season.active.or(Season.coming)
+ Season.in_progress.or(Season.coming)
  .joins(:league)
  .hashable_pluck(:id, :uuid, :start_at, :name, :updated_at, 'leagues.slug', 'leagues.sport_kind')
  end

app/controllers/fantasy_teams_controller.rb

@@ -53,7 +53,7 @@ def find_fantasy_team_relationships
  end
 
  def find_season
- @season = Season.active.find_by!(uuid: params[:season_id])
+ @season = Season.in_progress.find_by!(uuid: params[:season_id])
  end
 
  def fantasy_team_params

app/controllers/seasons/best_players_controller.rb

@@ -14,7 +14,7 @@ def index
  private
 
  def find_season
- @season = Season.active.find_by!(uuid: params[:season_id])
+ @season = Season.in_progress.find_by!(uuid: params[:season_id])
  end
 
  def find_week

app/controllers/seasons/players_controller.rb

@@ -17,7 +17,7 @@ def show
  private
 
  def find_season
- @season = Season.active.find_by!(uuid: params[:season_id])
+ @season = Season.in_progress.find_by!(uuid: params[:season_id])
  end
 
  def find_season_players

app/controllers/teams_controller.rb

@@ -11,7 +11,7 @@ def index
  private
 
  def find_teams
- @teams = Season.active.find_by!(uuid: params[:season_uuid]).teams
+ @teams = Season.in_progress.find_by!(uuid: params[:season_uuid]).teams
  end
 
  def teams

app/forms/seasons/create_form.rb

@@ -11,11 +11,7 @@ def call(params:)
  errors = validator.call(params: params)
  return { errors: errors } if errors.any?
 
- result = ActiveRecord::Base.transaction do
- # commento: seasons.name, seasons.active
- league.seasons.active.update!(active: false) if params[:active]
- league.seasons.create!(params)
- end
+ result = league.seasons.create!(params)
 
  { result: result }
  end

app/jobs/injuries/import_job.rb

@@ -5,7 +5,7 @@ class ImportJob < ApplicationJob
  queue_as :default
 
  def perform(import_service: Injuries::ImportService.new)
- Season.active.each do |season|
+ Season.in_progress.each do |season|
  import_service.call(season: season)
  end
  end

app/jobs/scheduler_job.rb

@@ -13,7 +13,7 @@ def perform
 
  def start_seasons
  # start season with updating first week as coming
- Season.active.where('start_at < ? AND start_at > ?', 15.minutes.after, 15.minutes.ago).each do |season|
+ Season.in_progress.where('start_at < ? AND start_at > ?', 15.minutes.after, 15.minutes.ago).each do |season|
  season.weeks.inactive.order(position: :asc).first.update(status: Week::COMING)
  end
  end
@@ -29,7 +29,7 @@ def import_games
  # fetch game statistics 1 time, 3 hours after game start and no points before
  # game started at 5:00 will be fetched at 8:00
  # game started at 5:30 will be fetched at 8:30
- Season.active.hashable_pluck(:id, :main_external_source).each do |season|
+ Season.in_progress.hashable_pluck(:id, :main_external_source).each do |season|
  game_ids =
  Game
  .joins(:week)

app/models/league.rb

@@ -4,7 +4,7 @@ class League < ApplicationRecord
  include Sportable
 
  has_many :seasons, dependent: :destroy
- has_one :active_season, -> { Season.active }, class_name: 'Season', foreign_key: :league_id # rubocop: disable Rails/HasManyOrHasOneDependent
+ has_one :active_season, -> { Season.in_progress }, class_name: 'Season', foreign_key: :league_id # rubocop: disable Rails/HasManyOrHasOneDependent
 
  has_many :cups, dependent: :destroy
 end

app/models/season.rb

@@ -6,6 +6,11 @@ class Season < ApplicationRecord
  include Placeable
  include Likeable
 
+ INACTIVE = 'inactive'
+ ACTIVE = 'active'
+ FINISHING = 'finishing'
+ FINISHED = 'finished'
+
  belongs_to :league
 
  has_many :seasons_teams, class_name: 'Seasons::Team', foreign_key: :season_id, dependent: :destroy
@@ -26,6 +31,12 @@ class Season < ApplicationRecord
  has_many :players, through: :players_seasons
  has_many :injuries, through: :players_seasons
 
- scope :active, -> { where(active: true) }
- scope :coming, -> { where(active: false).where.not(start_at: nil) }
+ scope :in_progress, -> { where(status: [ACTIVE, FINISHING]) }
+ scope :coming, -> { where(status: INACTIVE).where.not(start_at: nil) }
+
+ enum status: { INACTIVE => 0, ACTIVE => 1, FINISHING => 2, FINISHED => 3 }
+
+ def in_progress?
+ [ACTIVE, FINISHING].include?(status)
+ end
 end

app/views/components/page_wrappers/page_component.html.erb

@@ -34,7 +34,7 @@
  <% if @fantasy_team&.completed? %>
  <div class="flex-1 flex xl:border-l xl:border-stone-300 pl-4">
  <%= link_to t('components.views.shared.fantasy_team_navigation_component.points'), fantasy_team_points_path(@fantasy_team.uuid), class: "user-navigation-link #{'active' if current_page?(fantasy_team_points_path(@fantasy_team.uuid))}" %>
- <% if @fantasy_team.user_id == Current.user.id %>
+ <% if @fantasy_team.user_id == Current.user.id && season_in_progress? %>
  <%= link_to t('components.views.shared.fantasy_team_navigation_component.team'), fantasy_team_path(@fantasy_team.uuid), class: "user-navigation-link #{'active' if current_page?(fantasy_team_path(@fantasy_team.uuid))}" %>
  <%= link_to t('components.views.shared.fantasy_team_navigation_component.transfers'), fantasy_team_transfers_path(@fantasy_team.uuid), class: "user-navigation-link #{'active' if current_page?(fantasy_team_transfers_path(@fantasy_team.uuid))}" %>
  <% end %>

app/views/components/page_wrappers/page_component.rb

@@ -27,6 +27,10 @@ def global_user_oraculs
  .hashable_pluck(:uuid, :name, :placeable_id, :placeable_type)
  end
 
+ def season_in_progress?
+ @fantasy_team.season.in_progress?
+ end
+
  private
 
  def background_urls

app/views/controllers/admin/seasons/index.html.erb

@@ -18,7 +18,7 @@
  <tr>
  <td><%= season[:id] %></td>
  <td><%= season[:name] %></td>
- <td><%= season[:active] %></td>
+ <td><%= season[:status] %></td>
  <td>
  <%= link_to t('views.admin.seasons.index.weeks'), admin_weeks_path(season_id: season[:id]), class: 'btn-primary btn-small' %>
  <%= link_to t('views.admin.seasons.index.games'), admin_season_games_path(season[:uuid]), class: 'btn-primary btn-small' %>

app/views/controllers/admin/seasons/new.html.erb

@@ -6,8 +6,8 @@
  <%= form.text_field :name, class: 'form-value' %>
  </div>
  <div class="form-field">
- <%= form.label :active, t('views.admin.seasons.new.active'), class: 'form-label' %>
- <%= form.check_box :active, class: 'form-value' %>
+ <%= form.label :status, t('views.admin.seasons.new.active'), class: 'form-label' %>
+ <%= form.select :status, options_for_select(Season.statuses.keys), class: 'form-value' %>
  </div>
  <div class="form-field">
  <%= form.label :league_id, t('views.admin.seasons.new.league_id'), class: 'form-label' %>

db/migrate/20240417155344_add_finished_to_seasons.rb

@@ -0,0 +1,9 @@
+class AddFinishedToSeasons < ActiveRecord::Migration[7.1]
+ def change
+ add_column :seasons, :status, :integer, null: false, default: 0
+
+ Season.find_each do |season|
+ season.update!(status: season.active? ? Season::ACTIVE : Season::INACTIVE)
+ end
+ end
+end

db/structure.sql

@@ -1692,7 +1692,8 @@ CREATE TABLE public.seasons (
  start_at timestamp(6) without time zone,
  members_count integer DEFAULT 1 NOT NULL,
  main_external_source character varying,
- maintenance boolean DEFAULT false NOT NULL
+ maintenance boolean DEFAULT false NOT NULL,
+ status integer DEFAULT 0 NOT NULL
 );
 
 
@@ -3270,6 +3271,7 @@ ALTER TABLE ONLY public.kudos_achievements
 SET search_path TO "$user", public;
 
 INSERT INTO "schema_migrations" (version) VALUES
+('20240417155344'),
 ('20240329062740'),
 ('20240327093404'),
 ('20240327061925'),

spec/controllers/admin/seasons_controller_spec.rb

@@ -118,7 +118,7 @@
 
  context 'for valid params' do
  let(:request) {
- post :create, params: { season: { name: 'En', league_id: league.id }, locale: 'en' }
+ post :create, params: { season: { name: 'En', status: 'active', league_id: league.id }, locale: 'en' }
  }
 
  it 'creates season', :aggregate_failures do

spec/factories/seasons.rb

@@ -3,7 +3,7 @@
 FactoryBot.define do
  factory :season do
  name { '2021/2022' }
- active { true }
+ status { Season::ACTIVE }
  league
  end
 end

spec/forms/seasons/create_form_spec.rb

@@ -5,24 +5,22 @@
 
  let!(:instance) { described_class.new }
  let!(:league) { create :league }
- let!(:season) { create :season, league: league, active: true }
 
  context 'for invalid params' do
- let(:params) { { name: '', active: true, league_id: league.id } }
+ let(:params) { { name: '', status: Season::ACTIVE, league_id: league.id } }
 
- it 'does not create Season', :aggregate_failures do
+ it 'does not create season', :aggregate_failures do
  expect { form }.not_to change(Season, :count)
  expect(form[:errors]).not_to be_blank
  end
  end
 
  context 'for valid params' do
- let(:params) { { name: 'New', active: true, league_id: league.id } }
+ let(:params) { { name: 'New', status: Season::ACTIVE, league_id: league.id } }
 
- it 'creates Season', :aggregate_failures do
+ it 'creates season', :aggregate_failures do
  expect { form }.to change(league.seasons, :count).by(1)
  expect(form[:errors]).to be_blank
- expect(season.reload.active).to be_falsy
  end
  end
 end

spec/jobs/injuries/import_job_spec.rb

@@ -3,8 +3,8 @@
 describe Injuries::ImportJob do
  subject(:job_call) { described_class.perform_now(import_service: import_service) }
 
- let!(:season1) { create :season, active: true }
- let!(:season2) { create :season, active: false }
+ let!(:season1) { create :season, status: Season::ACTIVE }
+ let!(:season2) { create :season, status: Season::INACTIVE }
  let(:import_service) { instance_double(Injuries::ImportService, call: nil) }
 
  it 'imports injuries', :aggregate_failures do

spec/validators/season_validator_spec.rb

@@ -4,15 +4,15 @@
  subject(:validator_call) { described_class.new.call(params: params) }
 
  context 'for invalid name format' do
- let(:params) { { name: '' } }
+ let(:params) { { name: '', status: Season::ACTIVE } }
 
  it 'result contains error' do
  expect(validator_call.first).to eq("Name can't be blank")
  end
  end
 
  context 'for valid params' do
- let(:params) { { name: 'En' } }
+ let(:params) { { name: 'En', status: Season::ACTIVE } }
 
  it 'result does not contain errors' do
  expect(validator_call.empty?).to be_truthy