-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kotlin/JS #775
Support Kotlin/JS #775
Conversation
- Use bundles for js dependencies - Disable InstantInEpochMillisecondsSerializerTest for now
- Add test-kit - Add samples - Move HttpEngine to common
@DRSchlaubi we should update the PR description to include migration issues/steps (artifact changes, member to extension conversions), then it's good to go |
about annotation retention, this is how kxser does it, should we do it like this too? @MustBeDocumented
@Target(AnnotationTarget.PROPERTY, AnnotationTarget.CLASS, AnnotationTarget.TYPE)
//@Retention(AnnotationRetention.RUNTIME) // Runtime is the default retention, also see KT-41082
public annotation class Serializable(
val with: KClass<out KSerializer<*>> = KSerializer::class // Default value indicates that auto-generated serializer is used
) it would mean that it's still available at runtime on jvm at least, i.e. no breaking change |
IMO these annotations shouldn't have been on runtime to begin with |
but now they are, so why not keep it that way? |
I don't really see the benefit of keeping it |
alright, it's fine for me |
This PR attempts to provide Kotlin/JS support for Kord (see #69)
Breaking Changes
dev.kord.common.Locale.asJavaLocale
->import dev.kord.common.asJavaLocale
dev.kord.core.cache.KordCacheBuilder.lruCache
->import dev.kord.core.cache.lruCache
dev.kord.rest.builder.message.create.MessageCreateBuilder.addFile
->import dev.kord.rest.builder.message.create.addFile
dev.kord.rest.builder.message.modify.MessageModifyBuilder.addFile
->import dev.kord.rest.builder.message.modify.addFile
dev.kord.rest.request.RequestBuilder.file
->import dev.kord.rest.request.file
java.util.Locale
todev.kord.common.Locale
(if you really need to use the Java class, use theasJavaLocale
extension):dev.kord.core.entity.Guild.preferredLocale
dev.kord.rest.builder.guild.GuildModifyBuilder.preferredLocale
dev.kord.common.annotation
and thedev.kord.gateway.PrivilegedIntent
annotation now haveBINARY
instead ofRUNTIME
retention. This means they are no longer visible for reflection.-jvm
to their artifact IDs forkord-common
,kord-rest
,kord-gateway
andkord-core
.core-voice
capability has been removed, please use thekord-core-voice
artifact instead.