Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add membership screening #218

Closed
wants to merge 1 commit into from
Closed

Add membership screening #218

wants to merge 1 commit into from

Conversation

DRSchlaubi
Copy link
Member

Related to #121, #216

@DRSchlaubi
Add membership screening
21b3ab2 
- Adds discord/discord-api-docs#2396
- Add models
- Add rest requests
@HopeBaron HopeBaron mentioned this pull request Mar 26, 2021
Closed
HopeBaron
HopeBaron requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@HopeBaron HopeBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no core representation for member screening

common/src/main/kotlin/entity/DiscordGuild.kt
) {
@Serializable
enum class Type {
Copy link
Member

@HopeBaron HopeBaron Apr 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a more expresive name than Type, maybe FormFieldType(?)
Also use objects so we can have Unknown type in there

@DRSchlaubi
Copy link
Member Author

actually, they removed the docs for membership screening so I stopped implementing them until they do a PR adding them again

@HopeBaron
Copy link
Member

Any updates on this?

@DRSchlaubi
Copy link
Member Author

https://discord.com/developers/docs/resources/guild#membership-screening-object still has the warning and I don't see any PR changeing it so I guess no updates

@HopeBaron
Copy link
Member

Understood 👍

@HopeBaron HopeBaron changed the base branch from 0.7.x to 0.8.x October 3, 2021 06:51
@DRSchlaubi DRSchlaubi added the on hold Something is preventing this issue from being resolved label Jan 20, 2022
@DRSchlaubi DRSchlaubi mentioned this pull request Apr 17, 2022
Open
1 task
@lukellmann lukellmann force-pushed the 0.8.x branch 2 times, most recently from a1bb076 to 1e6718a Compare August 17, 2022 12:47
@HopeBaron HopeBaron closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HopeBaron HopeBaron HopeBaron requested changes

Assignees
No one assigned
Labels
on hold Something is preventing this issue from being resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRSchlaubi @HopeBaron