Skip to content

Commit

Permalink
Debug MacOS signing (#24)
Browse files Browse the repository at this point in the history
* Debug MacOS signing

* More debug

* Notarize binary

* Zip before notarizing

* Rollback unneeded
  • Loading branch information
undera committed Apr 4, 2024
1 parent e840117 commit 1e9a9bf
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ jobs:
CERTIFICATE_ID: ${{ secrets.CERTIFICATE_ID }}
- name: Test Binary is Signed
run: |
cat codesign.log
echo ===============================
cat notarytool.log
echo ===============================
codesign -dv dist/build_macos_darwin_arm64/komocli
- uses: actions/upload-artifact@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .goreleaser-mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ builds:
# sign
- codesign --options runtime --keychain build.keychain --sign "{{ .Env.CERTIFICATE_ID }}" "{{ .Path }}"
# notarize
- chmod +x scripts/notarize-macos-app.sh && ./scripts/notarize-macos-app.sh {{ .Path }}.zip
- scripts/notarize-macos-app.sh "{{ .Path }}"
archives:
- id: komocli
format: binary
5 changes: 3 additions & 2 deletions scripts/notarize-macos-app.sh
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#!/usr/bin/env sh
echo "Notarizing $1"
xcrun notarytool submit $1 \
zip $1.zip $1
xcrun notarytool submit $1.zip \
--apple-id "$MACOS_NOTARY_APPLE_ID" \
--team-id "$MACOS_NOTARY_TEAM_ID" \
--password "$MACOS_NOTARY_PASSWORD" \
--wait
--wait 2>&1 | tee -a notarytool.log

0 comments on commit 1e9a9bf

Please sign in to comment.