Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with selectedText solved #302

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

charles-7StarsSolutions

I had a problem with the selection of text and the possibility to create a link.
The problem was that the service was not shared between the toolbar and the editor itself.
I removed the providers references from the two components to the module.
(Also upgraded the project to Angular 10)

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #302 (4f67122) into master (1af7684) will decrease coverage by 0.02%.
The diff coverage is 13.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   19.45%   19.42%   -0.03%     
==========================================
  Files           7        7              
  Lines         478      489      +11     
  Branches      104      105       +1     
==========================================
+ Hits           93       95       +2     
- Misses        372      381       +9     
  Partials       13       13              
Impacted Files Coverage Δ
projects/angular-editor/src/lib/config.ts 50.00% <0.00%> (-50.00%) ⬇️
...angular-editor/src/lib/angular-editor.component.ts 15.34% <13.09%> (-0.55%) ⬇️
...editor/src/lib/angular-editor-toolbar.component.ts 17.32% <18.75%> (+0.38%) ⬆️
...s/angular-editor/src/lib/angular-editor.service.ts 4.62% <50.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af7684...4f67122. Read the comment docs.

@kolkov
Copy link
Owner

kolkov commented Oct 24, 2020

Hi! Check your PR please.

@charles-7StarsSolutions
Copy link
Author

Hi! Check your PR please.

Hi Andrey, what do you means by this ?
What must I check ?
(It is the first time I make a pull request).

Charles

@kolkov
Copy link
Owner

kolkov commented Oct 25, 2020

Hi! Check your PR please.

Hi Andrey, what do you means by this ?
What must I check ?
(It is the first time I make a pull request).

Charles

I think you pulled wrong branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants