Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #222: IE support #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #222: IE support #223

wants to merge 2 commits into from

Conversation

achrefabdennebi
Copy link

Hello Andrey, i fix the ie problems in angular IE:

Changes:

  • Replace includes() with indexOf() because includes() is not supported in IE.
  • Delete the link command, i found that document.queryCommandState('link') create an error ERROR CONTENT [OBJECT OBJECT] in IE.
  • Move the OnChangeContent from input event to keyup event.

Note:
the onInput() & includes() events are not supported in IE.

Expected Behavior:

IE support done

@achrefabdennebi achrefabdennebi changed the title FIX #222: IE support in angular editor Fix #222: IE support in angular editor Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #223 into master will increase coverage by 10.91%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #223       +/-   ##
===========================================
+ Coverage   22.06%   32.97%   +10.91%     
===========================================
  Files           7        7               
  Lines         485      564       +79     
  Branches      102      102               
===========================================
+ Hits          107      186       +79     
  Misses        366      366               
  Partials       12       12               
Impacted Files Coverage Δ
...editor/src/lib/angular-editor-toolbar.component.ts 30.06% <ø> (+8.19%) ⬆️
...s/angular-editor/src/lib/angular-editor.service.ts 20.15% <0.00%> (+16.41%) ⬆️
...angular-editor/src/lib/angular-editor.component.ts 27.22% <0.00%> (+9.47%) ⬆️
...ar-editor/src/lib/ae-select/ae-select.component.ts 62.50% <0.00%> (+9.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1552fc4...fba9124. Read the comment docs.

@achrefabdennebi achrefabdennebi changed the title Fix #222: IE support in angular editor Fix #222: IE support Apr 17, 2020
@kolkov
Copy link
Owner

kolkov commented Apr 18, 2020

Hi! I check this soon as possible. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants