-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(organizations): add theming/story for Mantine TextInput TASK-1378 #5424
Open
RuthShryock
wants to merge
23
commits into
main
Choose a base branch
from
task-1378-mantine-text-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+206
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it easier to migrate existing styles
…o kalvis/mantine-setup
### 📣 Summary Adds theming and storybook entry for Mantine Menu component. ### 📖 Description Adds basic theming for the Mantine Menu component, primarily aimed at providing necessary style and functionality for use in the organization members list. In this context, the Menu component will be replacing KoboDropdown, but the latter is used, for example, as a building block of KoboSelect, so not all uses of KoboDropdown are under consideration here. ### 👀 Preview steps Run storybook and compare "Dropdown" story to the Actions dropdown (right side icon button) currently used in the organization Member table. --------- Co-authored-by: Paulo Amorim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's global📣 Summary
Add theming and storybook for custom TextInput component.
💭 Notes
IconColors
so the icon color does not match perfectly to the TextBox icon color.👀 Preview steps
projectSettings.es6
:verify that...