Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the obsolete version attribute #351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akuukis
Copy link

@Akuukis Akuukis commented Oct 2, 2024

Avoid potential confusion on running ./run.py from kobo-install as suggested by the warning message.

before

$ ./run.py 
WARN[0000] /<redacted-path>/kobo-docker/docker-compose.maintenance.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.maintenance.override.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.frontend.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.frontend.override.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.maintenance.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.maintenance.override.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.backend.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] /<redacted-path>/kobo-docker/tmp01/docker-compose.backend.override.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
[+] Running 5/5
...

after

$ ./run.py 
[+] Running 5/5
...

@Akuukis Akuukis requested a review from noliveleger October 2, 2024 16:18
@noliveleger
Copy link
Contributor

Won't append until we support docker compose v1. But that's in the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants