Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update koa-vs-express.md #1654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jeffwillden
Copy link

As it was, this table made it look like Koa doesn't support routing, templating, sending files, jsonp, which is technically true, but there is Koa middleware built for each of those, so it's helpful to clarify that in the table, rather than leaving those cells empty. It paints Koa in a better light for those who are unfamiliar and are comparing their options, which is the target audience of this page.

As it was, this table made it look like Koa doesn't support routing, templating, sending files, jsonp, which is technically true, but there is Koa middleware built for each of those, so it's helpful to clarify that in the table, rather than leaving those cells empty. It paints Koa in a better light for those who are unfamiliar and are comparing their options, which is the target audience of this page.
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1654 (b9c263d) into master (cc4cc1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1654   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4cc1f...b9c263d. Read the comment docs.

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect also support all of these features via middleware...

@miwnwski
Copy link
Member

miwnwski commented Jul 1, 2022

I can only guess but I imagine the entire point of that table is exactly that, to put significance on Koa's no bloat approach.
Instead of changing that table, I would have a separate table with some useful @koajs/plugins instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants