Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing cleanup, if response socket is no longer writeable (issue 1547) #1593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Azlond
Copy link

@Azlond Azlond commented Sep 28, 2021

Relates to issue #1547, see my comment there

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1593 (d7570c8) into master (7d8955b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d7570c8 differs from pull request most recent head bae657d. Consider uploading reports for the commit bae657d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1593   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           
Impacted Files Coverage Δ
lib/application.js 98.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8955b...bae657d. Read the comment docs.

Copy link
Member

@miwnwski miwnwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though would you mind adding a test for this?

@Azlond
Copy link
Author

Azlond commented Oct 11, 2022

I don't really know how to write tests for koa, so not sure if I can be of help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants