Change OCI Layout publisher to lazy create layout after build. #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted in #1378 |
imjasonh
approved these changes
Oct 16, 2024
When using ko with OCI Layout, Git status will always be dirty because the layout is created before this build. This changes the layout to be created after the build so that git will be clean. The means that any error creating the layout won't be seen until after the build. Signed-off-by: Jeff Mendoza <[email protected]>
jeffmendoza
force-pushed
the
layout-lazy-create
branch
from
3faa7b1
to
6bb2178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ko with OCI Layout, Git status will always be dirty because the layout is created before this build. This changes the layout to be created after the build so that git will be clean. The means that any error creating the layout won't be seen until after the build.