Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop estargz-optimizing #1015

Closed
wants to merge 5 commits into from
Closed

stop estargz-optimizing #1015

wants to merge 5 commits into from

Conversation

imjasonh
Copy link
Member

This didn't do anything unless GGCR_EXPERIMENTAL_ESTARGZ was also set, but if it was it would tell estargz to prioritize fetching the app binary.

In light of google/go-containerregistry#1660 we don't want to use this deprecated method.

@codecov-commenter
Copy link

Codecov Report

Merging #1015 (1814a84) into main (ba63655) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files          43       43           
  Lines        3348     3348           
=======================================
  Hits         1768     1768           
  Misses       1355     1355           
  Partials      225      225           
Impacted Files Coverage Δ
pkg/build/gobuild.go 57.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh enabled auto-merge (squash) April 20, 2023 22:33
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@imjasonh imjasonh closed this Sep 11, 2023
auto-merge was automatically disabled September 11, 2023 12:47

Pull request was closed

@imjasonh imjasonh reopened this Sep 11, 2023
@cpanato
Copy link
Member

cpanato commented Sep 11, 2023

@imjasonh maybe a rebase here :)

@imjasonh
Copy link
Member Author

Fixed in #1142

@imjasonh imjasonh closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants