Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump http lib version #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danReynolds
Copy link

Looking to bump to the 1.0 HTTP lib.

@@ -10,7 +10,7 @@ environment:

dependencies:
meta: ^1.6.0
http: ^0.13.0
http: ^1.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it less restrictive, i.e.

http: ">=0.13.0 <2.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it less restrictive, i.e.

http: ">=0.13.0 <2.0.0"

Cause some other packages use http 1.0.0 already. It means that we need to downgrade all others, in order to work with algolia

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you understood the version restriction above.

Btw, you can always resort to dependency_overrides if your requirement for ^1.0.0 is so dire.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest going with http: ">=0.13.0 <2.0.0" as well. It would greatly ease transition.

See for example the google sign-in package

@nzackoya
Copy link

Please merge as soon as possible. Currently in order not to face issues with version incompatibility, I'll need to use this branch as a patch

@iDaviddd
Copy link

bump

@treeder
Copy link

treeder commented Jul 12, 2023

Would be nice to get this in.

@NeatFastro
Copy link

any update for the merger date?

@techouse
Copy link

techouse commented Aug 15, 2023

any update for the merger date?

In the mantime you can simply do

dependency_overrides:
  http: ^1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants