fix: re-order change types #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for knope ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks like this would also change the order of the sections in the generated changelog, which we don't want (most important changes should be at the top). We probably need to sort the change types only for the prompt |
|
Ah, that makes sense - I'll take a look at that and put in another fix if you're happy with the initial suggestion? |
|
Yeah, definitely like the idea of ordering by most likely to be selected to save a couple of keystrokes. Maybe in the future it can even get smarter about those suggestions... somehow. |
|
Just got back from holiday so I'll take a look at this one shortly 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #916 by reordering the change types: