Stackpack: Gitea #29
Stackpack: Gitea #29
Conversation
| tmp_dir = TempDir() | ||
| if regen: | ||
| logger.info("Regenerating iac for %s", user_pack.id) | ||
| stack_packs = get_stack_packs() | ||
| _, iac = await user_pack.run_pack(stack_packs, store, tmp_dir.dir) | ||
| else: | ||
| iac = store.get_iac(user_pack.id) |
There was a problem hiding this comment.
just as a note, were always going to have to regenerate if the base stack hasnt been deployed since we wont know the imports yet, so this will likely change a little soon
There was a problem hiding this comment.
Yeah, makes sense. I just made this real quick since I kept forgetting to run the PATCH before install.
| # Make sure the SG rule is added to allow the LB in public subnets | ||
| # to talk to the ECS service in private subnets | ||
| aws:load_balancer:gitea-lb -> aws:ecs_service:gitea-service: |
There was a problem hiding this comment.
yeah this is an important note for all of them, we should still always have explicit edges between our major resources to ensure path solving runs
There was a problem hiding this comment.
Feels like this should be solvable from the engine to prevent such situations (took me a bit of investigation to figure out this was happening). In the meantime though, explicit edges will be required as you mentioned.
Requires klothoplatform/klotho#952
Also includes:
KEEP_TMPregenquery parameter to install to force regeneration, useful for testing